Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

[Andrew Morton]

On Fri, 29 May 2015 12:35:46 -0400 Dan Streetman <ddstreet@xxxxxxxx> wrote:

> On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> > On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote:
> >> because they are available for public use, per zpool.h?  If, e.g.,
> >> zram ever started using zpool, it would need them exported, wouldn't
> >> it?
> >
> > If you want to use it in ram export it in the same series as those
> > changes, and explain what the exprots are for in your message body.
> >
> 
> I don't want to use it in zram.  I wrote zpool, but neglected to
> export the functions.  They should be exported though.
> 
> What's your reasoning for not wanting them exported?

It's just noise which has no value.  Adding exports when there is a
demonstrated need is an OK approach.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/