Re: [PATCH V2 3/3] Drivers: hv: vmbus: Allocate ring buffer memory in NUMA aware fashion

[Greg KH]

On Sat, May 30, 2015 at 11:37:49PM -0700, K. Y. Srinivasan wrote:
> Allocate ring buffer memory from the NUMA node assigned to the channel.

But you do more than just that.  If there's a failure, you fall-back to
the old allocation method.  Why not mention that as well?

And is that what you really want?  Do we ever fail allocation for a node
but still have memory from another one?  Shouldn't the logic be in the
allocator and not be forced to be in every caller?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/