Re: [PATCH 1/5] drivers:usb:fsl: Check IP version 2.4 for mph USB controller

[Greg KH]

On Tue, May 26, 2015 at 05:14:42PM +0530, Nikhil Badola wrote:
> Check IP version 2.4 for multi port host USB controller and
> return FSL_USB_VER_2_4 macro
> 
> Signed-off-by: Nikhil Badola <nikhil.badola@xxxxxxxxxxxxx>
> ---
> Separate patches clubbed and resent in an ordered patchset
> with proper mailing list in cc
> 
>  drivers/usb/host/fsl-mph-dr-of.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
> index 7e325e9..e588ccd 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -126,6 +126,7 @@ static int usb_get_ver_info(struct device_node *np)
>  	/*
>  	 * returns 1 for usb controller version 1.6
>  	 * returns 2 for usb controller version 2.2
> +	 * returns 3 for usb controller version 2.4
>  	 * returns 0 otherwise

Shouldn't the comment use the #define names instead of values?

You can do that in a later patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/