Re: [RFC PATCH v2] suspend/resume performance improvement

[Rafael J. Wysocki]

On Sunday, May 31, 2015 05:07:42 AM EunTaik Lee wrote:
> When a task that calls state_store() to suspend
> the device has used up most of its time slice,
> suspend sometimes take too long. (User noticeable)

How long?  Perhaps this is not the only explanation of the delay?

> Suspend/resume is a system wide operation.
> So, instead of depending on a userspace task's time
> slice, let kworker do the work to avoid a long wait
> on the runqueue.
> 
> Signed-off-by: Eun Taik Lee <eun.taik.lee@xxxxxxxxxxx>

First, if you send a v2, please say what's changed since v1.

Second, this most likely is hiding a problem of some sort and the theory
about the time slice being used up entirely by the suspend process is not
convincing.

Also the patch duplicates exsiting functionality that should be extended
instead if anything.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/