Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

[Jiri Olsa]

On Fri, May 29, 2015 at 10:49:27PM -0700, Andi Kleen wrote:
> On Fri, May 29, 2015 at 11:13:15AM +0200, Jiri Olsa wrote:
> > On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote:
> > > Jiri Olsa [jolsa@xxxxxxxxxx] wrote:
> > > | >  		if (line[0] == '#' || line[0] == '\n')
> > > | >  			continue;
> > > | > +		if (!strncmp(line, "Family", 6))
> > > | > +			continue;
> > > | 
> > > | I think we should fix mapfiles to put the 'Family' starting
> > > | line as a comment.. the way powerpc mapfile is done
> > > 
> > > You mean add something like this to the Intel mapfile:
> > > 
> > > 	# Power8 entries
> > > 	004d0100,1,power8.json,core
> > > 
> > > and drop this patch?
> > 
> > right
> 
> But it's a CSV file. CSV files are supposed to have column headers.
> There are lots of tools that work better with them if they have headers.

header could be behind '#'

> Please keep the header.

hum, do all arch start with 'Family' column? I guess not, so eventualy
we will need to add first column of each arch in here? ending up with
list of 'keywords' which we ignore

or let's just ignore first line?

I'd rather go with just one comment char and place the header behind it

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/