Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

From: Sergei Shtylyov
Date: Mon Jun 01 2015 - 09:51:46 EST


Hello.

On 6/1/2015 1:43 AM, Colin King wrote:

From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

If kzalloc returns null then isp1760_ep_alloc_request performs
a null pointer dereference on req. Check for null to avoid this.

I told you there's no dereference and yet you're repeating it again. :-(

Detected with smatch static analysis:

drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request()
error: potential null dereference 'req'. (kzalloc returns null)

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/