Re: [PATCH 05/11] perf, tools, report: Add processing for cycle histograms

From: Jiri Olsa
Date: Mon Jun 01 2015 - 10:11:02 EST


On Wed, May 27, 2015 at 10:51:48AM -0700, Andi Kleen wrote:

SNIP

> +void hist__account_cycles(struct branch_stack *bs, struct addr_location *al,
> + struct perf_sample *sample, bool nonany_branch_mode)
> +{
> + struct branch_info *bi;
> +
> + /* If we have branch cycles always annotate them. */
> + if (bs && bs->nr && bs->entries[0].flags.cycles) {
> + int i;
> +
> + bi = sample__resolve_bstack(sample, al);
> + if (bi) {
> + struct addr_map_symbol *prev = NULL;
> +
> + /*
> + * Ignore errors, still want to process the
> + * other entries.
> + *
> + * For non standard branch modes always
> + * force no IPC (prev == NULL)
> + *
> + * Note that perf stores branches reversed from
> + * program order!
> + */
> + for (i = bs->nr - 1; i >= 0; i--) {
> + addr_map_symbol__account_cycles(&bi[i].from,
> + nonany_branch_mode ? NULL : prev,
> + bi[i].flags.cycles);

it's only ERANGE you want to ignore here

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/