Re: [PATCH v2 1/3] megaraid : use dev_printk when possible

[Joe Perches]

On Mon, 2015-06-01 at 10:40 -0500, Bjorn Helgaas wrote:
> Use dev_printk() when possible to make messages more useful.
[]
> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
[]
> @@ -268,7 +268,7 @@ mega_query_adapter(adapter_t *adapter)
>  		raw_mbox[2] = NC_SUBOP_PRODUCT_INFO;	/* i.e. 0x0E */
>  
>  		if ((retval = issue_scb_block(adapter, raw_mbox)))
> -			printk(KERN_WARNING
> +			dev_warn(&adapter->dev->dev,
>  			"megaraid: Product_info cmd failed with error: %d\n",
>  				retval);

Wouldn't these be a bit redundant with a "megaraid: " prefix now?
Perhaps it'd be nicer to realign arguments too.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/