Re: [PATCH] x86_32, entry, selftests: Add a selftest for kernel entries from vm86 mode

[Andy Lutomirski]

On Mon, Jun 1, 2015 at 4:27 PM, Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
> On 06/01/2015 04:54 PM, Andy Lutomirski wrote:
>> On Mon, Jun 1, 2015 at 9:02 AM, Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
>>> On 05/29/2015 03:58 PM, Andy Lutomirski wrote:
>>>> Test a couple of special cases in 32-bit kernels for entries from
>>>> vm86 mode.  This will OOPS both old kernels due to a bug and and
>>>> 4.1-rc5 due to a regression I introduced, and it should make sure
>>>> that the SYSENTER-from-vm86-mode hack in the kernel keeps working.
>>>>
>>>> Tests: 394838c96013 x86/asm/entry/32: Fix user_mode() misuses
>>>> Tests: 7ba554b5ac69 x86/asm/entry/32: Really make user_mode() work correctly for VM86 mode
>>>> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
>>>> ---
>>>>
>>>> Ingo, Shuah: I think this should go in through -tip.  (In general, I think
>>>> new x86 tests that don't have interesting interactions with the kselftest
>>>> infrastructure should go in through -tip, especially tests such as this one
>>>> that are related to recent regressions.)
>>>
>>> No problem going through tip. Could you please make sure
>>>
>>> "make kselftest" run from top level and
>>> tools/testing/selftests/kselftest_install.sh
>>>
>>> don't break?
>>
>> Both 'make kselftest -j12 TARGETS=x86' and
>> ../../../tools/testing/selftests/kselftest_install.sh work for me.
>> (The .. thing is annoying -- would it make sense to fix it to work
>> from the kernel tree root?)
>>
>
> What is annoying about it and how would it get solved by making it
> run from the kernel tree root?
>

I ran it from the kernel tree root and it told me to change my
directory.  I think it should have changed the directory itself :)

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/