Re: [RFC PATCH v5 00/30] perf tools: filtering events using eBPF programs

From: Alexei Starovoitov
Date: Mon Jun 01 2015 - 20:48:34 EST


On Mon, Jun 01, 2015 at 07:37:46AM +0000, Wang Nan wrote:
> This is the 5th version of patch series which tries to introduce eBPF
> programs to perf. It enables 'perf record' to filter events using eBPF

thanks! As far as I could review this set addresses all of my earlier comments.

> Patch 4/30 - 22/30 introduce libbpf, which first parse eBPF object
> files then load maps and programs into kernel.

the libbpf side looks good.
For the patches that I haven't explictly acked yet:
Acked-by: Alexei Starovoitov <ast@xxxxxxxxxxxx>

> Patch 23-30 - 30/30 are perf side modifications, introducing
> new syntax: '--event [.*].(o|bpf)' to enable passing eBPF object
> files to 'perf record', create probing points and attach programs
> to those points.

Looks good to me as well.
Arnaldo, please take a deep look :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/