Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag

[Jacek Anaszewski]

On 06/01/2015 04:37 PM, Stas Sergeev wrote:
> 01.06.2015 17:19, Jacek Anaszewski ÐÐÑÐÑ:
> > > In fact, the things are more complicated: some drivers do small
> > > udelay()'s but do not use a work-queue. I was not marking them as
> > > FAST, although perhaps they could still be marked as SYNC?
> > This could be handled by adding a property to struct led_classdev
> > for defining minimum acceptable delay. Then FAST flag should not
> > be needed.
> Oh c'mon, that's too difficult!
> Lets just have a flag whether we can do an SW PWM from hrtimer irq callback.
> If we can't do from irq callback - simply do not do anything below 10mS.
> IMHO a simple and practical solution.
> Otherwise we'll not have anything implemented at all I guess.

I agree if we are not going to mark the drivers using delays as FAST.
Otherwise the minimum acceptable value stemming from delay value
would be required. I prefer the former.

--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/