Re: [PATCH] Documentation, intel_pstate: Add a better description of the intel_pstate legacy mode internal governors

From: Prarit Bhargava
Date: Tue Jun 02 2015 - 05:44:16 EST




On 06/02/2015 12:02 AM, Viresh Kumar wrote:
> On 01-06-15, 09:36, Prarit Bhargava wrote:
>> This patchset was originally submitted and acked here
>>
>> http://marc.info/?l=linux-kernel&m=140203008832333&w=2
>>
>> but lost at some point.
>>
>> P.
>>
>> ----8<----
>
> I don't think this is the right place to have this information, you
> should have added it after the three dashes below. (---).

AFAIK "scissors" works for comments not to be included in the commit.

>
>> The current documentation is incomplete wrt the intel_pstate legacy
>> internal governors. The confusion comes from the general cpufreq
>> governors which also use the names performance and powersave. This patch
>> better differentiates between the two sets of governors and gives an
>> explanation of how the internal P-state governors behave differently from
>> one another.
>>
>> Also fix two minor typos.
>>
>> Cc: Jonathan Corbet <corbet@xxxxxxx>
>> Cc: Prarit Bhargava <prarit@xxxxxxxxxx>
>> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
>> Cc: Kristen Carlson Accardi <kristen@xxxxxxxxxxxxxxx>
>> Cc: Dirk Brandewie <dirk.j.brandewie@xxxxxxxxx>
>> Cc: linux-doc@xxxxxxxxxxxxxxx
>> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>> Cc: x86@xxxxxxxxxx
>> Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
>
> You could have carried my Ack :)

:) I was uncomfortable carrying it TBH because I had changed the patch.

P.

>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/