Re: [PATCH] lockdep: Add missing space in error message

[Ingo Molnar]

* Borislav Petkov <bp@xxxxxxxxx> wrote:

> From: Borislav Petkov <bp@xxxxxxx>
> 
> ... to fix this:
> 
> WARNING: lockdep init error! lock-(console_sem).lock was acquiredbefore lockdep_init
> 
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
> ---
>  kernel/locking/lockdep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index a0831e1b99f4..041ac1add184 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -4066,7 +4066,7 @@ void __init lockdep_info(void)
>  
>  #ifdef CONFIG_DEBUG_LOCKDEP
>  	if (lockdep_init_error) {
> -		printk("WARNING: lockdep init error! lock-%s was acquired"
> +		printk("WARNING: lockdep init error! lock-%s was acquired "
>  			"before lockdep_init\n", lock_init_error);

Please also fix the cause, not just the symptom: the cause is the unnecessary 
line-break in the middle of a user visible string.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/