Re: [PATCH 2/3] of: make CONFIG_OF user selectable

[Geert Uytterhoeven]

Hi Rob,

On Wed, Jun 3, 2015 at 12:46 AM, Rob Herring <robh@xxxxxxxxxx> wrote:
> With the addition of overlays, it is now plausible to use DT on any arch
> and without an arch using it at boot time. It is also desirable to
> expand the compile coverage of the DT code. Make CONFIG_OF user
> selectable by converting the menu to menuconfig.

Thanks!

> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx>
> Cc: Grant Likely <grant.likely@xxxxxxxxxx>

Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
with one minor docu nit below.

> ---
>  drivers/of/Kconfig | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 07bb3c8..415b51d 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -1,11 +1,10 @@
>  config DTC
>         bool
>
> -config OF
> -       bool
> +menuconfig OF
> +       bool "Device Tree and Open Firmware support"

This needs a help text. In "[PATCH 1/3] of: Allow OF to be enabled if
COMPILE_TEST to increase coverage", I had:

+         This option enables the device tree infrastructure.
+         If is automatically selected by platforms that need it, but can
+         be enabled manually to increase compile-coverage.

Feel free to adapt...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/