Re: [RFC 07/24] x86/thinkpad_acpi: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte()

From: Finn Thain
Date: Wed Jun 03 2015 - 03:38:33 EST



On Tue, 2 Jun 2015, Darren Hart wrote:

> On Tue, Jun 02, 2015 at 07:09:28AM -0300, Henrique de Moraes Holschuh
> wrote:
> > Test results were sent to me privately, and they are correct, so...
> >
>
> Finn, unless there is some compelling reason not to - like they are MBs
> worth of data, please submit these to the list in the future so we have
> them for reference.

Sure. Those results were just confirmation that this patch series doesn't
affect input events read directly from
/dev/input/by-path/platform-thinkpad_acpi-event
given the the hotkey_source_mask settings discussed in this thread.

>
> > Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
>
> I'm fine with the changes, but they need to be submitted with the other
> changes as this one change cannot compile independently in my tree.
>
> Finn, please work with whomever is pulling the series to include this in
> their pull request.

Right.

>
> Reviewed-by: Darren Hart <dvhart@xxxxxxxxxxxxxxx>

Thanks for your review.

--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/