Re: [PATCH v13 11/14] perf, tools: Support long descriptions with perf list -v

From: Jiri Olsa
Date: Wed Jun 03 2015 - 06:32:43 EST


On Tue, Jun 02, 2015 at 10:12:11AM -0700, Sukadev Bhattiprolu wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> Previously we were dropping the useful longer descriptions that some
> events have in the event list completely. This patch makes them appear with
> perf list.
>
> Old perf list:
>
> baclears:
> baclears.all
> [Counts the number of baclears]
>
> vs new:
>
> perf list -v:
> ...
> baclears:
> baclears.all
> [The BACLEARS event counts the number of times the front end is resteered, mainly when
> the Branch Prediction Unit cannot provide a correct prediction and this is corrected
> by the Branch Address Calculator at the front end. The BACLEARS.ANY event counts the
> number of baclears for any type of branch]
>
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
> ---
> tools/perf/builtin-list.c | 9 ++++++---
> tools/perf/pmu-events/jevents.c | 29 ++++++++++++++++++++---------
> tools/perf/pmu-events/jevents.h | 2 +-
> tools/perf/pmu-events/pmu-events.h | 1 +
> tools/perf/util/parse-events.c | 4 ++--
> tools/perf/util/parse-events.h | 2 +-
> tools/perf/util/pmu.c | 17 ++++++++++++-----
> tools/perf/util/pmu.h | 4 +++-
> 8 files changed, 46 insertions(+), 22 deletions(-)

I think this change should be split into:
- jevents update of parsing out PublicDescription tag
- alias support for long_desc
- perf list update

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/