Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

[Malcolm Priestley]

On 03/06/15 17:43, Antti Palosaari wrote:
> On 06/03/2015 07:37 PM, David Howells wrote:
> > Malcolm Priestley <tvboxspy@xxxxxxxxx> wrote:
> >
> > > > > Yes, also, the workqueue appears not to be initialized when using
> > > > > the dvb
> > > > > attached method.
> > > >
> > > > I'm not sure what you're referring to.  It's initialised in
> > > > ts2020_probe()
> > > > just after the ts2020_priv struct is allocated - the only place it is
> > > > allocated.
> > > ts2020_probe() isn't touched by devices not converted to I2C binding.
> >
> > Hmmm...  Doesn't that expose a larger problem?  The only place the
> > ts2020_priv
> > struct is allocated is in ts2020_probe() within ts2020.c and the struct
> > definition is private to that file and so it can't be allocated from
> > outside.
> > So if you don't pass through ts2020_probe(), fe->tuner_priv will
> > remain NULL
> > and the driver will crash.
>
> Malcolm misses some pending patches where attach() is wrapped to I2C
> model probe().
> http://git.linuxtv.org/cgit.cgi/anttip/media_tree.git/log/?h=ts2020

Hmmm... Yes, I am indeed missing those patches.

I will test.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/