Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver

[Timur Tabi]

On 06/01/2015 11:05 PM, fu.wei@xxxxxxxxxx wrote:
> +	if (wdd->pretimeout)
> +		/* The pretimeout is valid, go panic */
> +		panic("SBSA Watchdog pre-timeout");

The problem with this is that WS1 will still occur.  So a few seconds 
after the panic() call, the hardware will reset.  There won't be any 
time to debug or log anything.

> +		/* We don't use pretimeout, trigger WS1 now*/
> +		sbsa_gwdt_set_wcv(wdd, 0);

Are you sure this will work?   This will set WCV to 0, which means it 
the WS1 reset won't happen until the timestamp counter wraps around to 
0.  That could be a very long time from now.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/