Re: [PATCH] x86/asm/msr: Retract msr-index.h

From: H. Peter Anvin
Date: Wed Jun 03 2015 - 14:57:29 EST


On 06/03/2015 11:21 AM, Borislav Petkov wrote:
> On Wed, Jun 03, 2015 at 02:41:48PM +0200, Borislav Petkov wrote:
>> This header containing all MSRs and respective bit definitions got
>> exported to userspace in conjunction with the big uapi shuffle.
>>
>> But, it doesn't have anything to do in the uapi headers because
>> userspace can do its own MSR defines and exporting them from the
>> kernel blocks us from doing cleanups/renames in that header. Which is
>> ridiculous - it is not kernel's job to export such a header and keep
>> MSRs list and their names stable.
>
> Here's v2. Needed to *not* include it into uapi/asm/msr.h either.

I really like the patch, but the description is awful.

How about: "x86/uapi: <asm/msr.h> is not a UAPI"

-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/