Re: kernel/params.c: 'err' variable "set but not used" and perhaps should be?

[Tejun Heo]

On Thu, Jun 04, 2015 at 11:03:16AM +0930, Rusty Russell wrote:
> Please describe the circumstances under which this function can fail.

Allocation failure obviously and violatin of certain API rules -
e.g. dup names, wrong nesting, activation rule violations.  Some can
be warned automatically but I'm not sure about e.g. activation rule
violation.

Also, please note that w/ kmemcg order-0 allocation failures are a lot
more common and we probably won't want to print out warnings
automatically.  For module's use case, it can just trigger warnings
and continue on but I don't think it'd be a good idea to cripple the
API by making it trigger warnings internally and then make it return
void.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/