Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros definition

[Madhavan Srinivasan]

On Wednesday 03 June 2015 04:41 AM, Daniel Axtens wrote:
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * as published by the Free Software Foundation; either version
> > + * 2 of the License, or (at your option) any later version.
> > + */
> I'm not certain about this, but I _think_ this is supposed to be version
> 2 only:
> http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/COPYING#n9
I referred other files for license information from the same folder. So 
I could wait
for the maintainers comment on this.
> > +/*
> > + * Device tree parser code detect nest pmu support
> > + * and create new nest pmus. This structure will
> > + * hold the pmu functions and attrs for each nest pmu and
> > + * will be referenced at the time of pmu registering.
> > + */
> The first sentence of that comment is unclear: I think your trying to
> say "Device tree parser code detects nest pmu support and registers new
> nest pmus"? Also s/registering/registration/.
Yes. I will rewrite the comment.

> > +struct nest_pmu {
> > +	struct pmu pmu;
> > +	const struct attribute_group *attr_groups[4];
> > +};
> > +
> Regards,
> Daniel Axtens
Thanks for the review
Maddy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/