Re: [PATCH] staging: fbtft: fix out of bound access

[Sudip Mukherjee]

On Thu, Jun 04, 2015 at 03:36:31PM +0300, Dan Carpenter wrote:
> On Thu, Jun 04, 2015 at 05:12:01PM +0530, Sudip Mukherjee wrote:
> > size of str is 16, but in snprintf the size was mentioned as 128.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> > ---
<snip>
> Good eye.  How did you find this?
:) not me. cppcheck. 
> 
> The good news is buf[j] is <= 0xFFFF so it won't actually overflow.  Who
> knows why it is zero padded 2 spaces...  But use sizeof(str) instead of
> 16.
but my v2 will remove the use of msg and str.

regards
sudip
> 
> regards,
> dan carpenter
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/