Re: [PATCH 1/2] dmaengine: at_xdmac: lock fixes

[Vinod Koul]

On Thu, Jun 04, 2015 at 05:09:46PM +0200, Ludovic Desroches wrote:
> > > @@ -591,11 +592,13 @@ at_xdmac_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
> > >  		       unsigned int sg_len, enum dma_transfer_direction direction,
> > >  		       unsigned long flags, void *context)
> > >  {
> > > -	struct at_xdmac_chan	*atchan = to_at_xdmac_chan(chan);
> > > -	struct at_xdmac_desc	*first = NULL, *prev = NULL;
> > > -	struct scatterlist	*sg;
> > > -	int			i;
> > > -	unsigned int		xfer_size = 0;
> > > +	struct at_xdmac_chan		*atchan = to_at_xdmac_chan(chan);
> > > +	struct at_xdmac_desc		*first = NULL, *prev = NULL;
> > > +	struct scatterlist		*sg;
> > > +	int				i;
> > > +	unsigned int			xfer_size = 0;
> > > +	unsigned long			irqflags;
> > > +	struct dma_async_tx_descriptor	*ret = NULL;
> > This doesnt comply with stable rules, and you should not keep this in fixes
> > either :(
> > 
> >   - It cannot contain any "trivial" fixes in it (spelling changes,
> >     whitespace cleanups, etc).
> 
> Ok I understand, so what is the way to manage this case? I did
> "whitespace cleanup" because of
> +   struct dma_async_tx_descriptor  *ret = NULL;
> which breaks previous indentation, so in my mind it was not cleanup.
> 
> Do I need to send you a patch to correct identation due to this fix or to send
> a specific patch for stable without identation change?
I think only adding the last line should do, in whatever indentation you
prefer

Later on if you want to align them to whatever alignment you prefer send a
follow on patch

Also on 2nd patch, it looks good, but was wondering if you could split it
up. This will help folks backporting the changes to stable as well

Thanks
-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/