Re: [RFC PATCH 11/12] mm: add the PCP interface

From: Dave Hansen
Date: Thu Jun 04 2015 - 14:44:49 EST


On 06/04/2015 06:04 AM, Xishi Qiu wrote:
> spin_lock(&zone->lock);
> for (i = 0; i < count; ++i) {
> - struct page *page = __rmqueue(zone, order, migratetype);
> + struct page *page;
> +
> + if (is_migrate_mirror(migratetype))
> + page = __rmqueue_smallest(zone, order, migratetype);
> + else
> + page = __rmqueue(zone, order, migratetype);
> if (unlikely(page == NULL))
> break;

Why is this necessary/helpful? The changelog doesn't tell me either. :(

Why was this code modified in stead of putting the changes in
__rmqueue() itself (like CMA did)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/