Re: [RFC/PATCH 5/8] drivers/base/core.c: Use strreplace

[Al Viro]

On Thu, Jun 04, 2015 at 11:37:12AM +0200, Rasmus Villemoes wrote:
> This eliminates a local variable and a little .text.

Hmm...

>  	*tmp = kstrdup(dev_name(dev), GFP_KERNEL);
>  	if (!*tmp)
>  		return NULL;
> -	while ((s = strchr(*tmp, '!')))
> -		s[0] = '/';
> +	strreplace((char *)*tmp, '!', '/');
>  	return *tmp;

That cast isn't nice.  Why not make it
	s = kstrdup(...)
	if (s)
		strreplace(s, ...)
	return *tmp = s;
instead?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/