Re: [PATCH v3 5/8] staging:lustre: separate kernel and user land defines in the LNet headers

From: Dan Carpenter
Date: Fri Jun 05 2015 - 05:03:27 EST


On Wed, Jun 03, 2015 at 04:43:24PM -0400, James Simmons wrote:
> Currently the lnet headers used by user land contain various internal
> LNet structures that are only used by kernel space. Move the user land
> structures to headers used by user land. The kernel structures are
> relocated to headers that are never exposed to user land.
>
> Signed-off-by: James Simmons <jsimmons@xxxxxxxxxxxxx>
> ---
> diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c
> index 1dc7c8a..4928f5c 100644
> --- a/drivers/staging/lustre/lnet/lnet/acceptor.c
> +++ b/drivers/staging/lustre/lnet/lnet/acceptor.c
> @@ -243,8 +243,6 @@ lnet_accept(struct socket *sock, __u32 magic)
>
> if (magic == le32_to_cpu(LNET_PROTO_TCP_MAGIC))
> str = "'old' socknal/tcpnal";
> - else if (lnet_accept_magic(magic, LNET_PROTO_RA_MAGIC))
> - str = "'old' ranal";
> else
> str = "unrecognised";
>

Presumably this was done intentionally. We deleted LNET_PROTO_RA_MAGIC.
The changelog was not very clear why.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/