Re: [PATCH 14/14] sched,lockdep: Employ lock pinning

[Peter Zijlstra]

On Fri, 2015-06-05 at 11:57 +0200, Ingo Molnar wrote:
> * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> 
> > Employ the new lockdep lock pinning annotation to ensure no
> > 'accidental' lock-breaks happen with rq->lock.
> 
> btw., could we perhaps reorder this series a bit and first see that it properly 
> detects the original locking bug, and then only fix the bug?
> 
> To make sure the pinning infrastructure works and all that.

It works; I've had plenty explosions while trying to get some of the
less obvious code paths sorted. I've managed to hit every single WARN I
added ;-)

Also, for bisection it might be annoying to hit known bad points, which
is why its ordered this way.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/