Re: [PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>, depend on GPIOLIB

[Thierry Reding]

On Tue, May 05, 2015 at 06:32:17PM +0200, Geert Uytterhoeven wrote:
> If GPIOLIB=n and asm-generic/gpio.h is not used:
> 
>     drivers/gpu/drm/bridge/ptn3460.c: In function âptn3460_pre_enableâ:
>     drivers/gpu/drm/bridge/ptn3460.c:135: error: implicit declaration of function âgpiod_set_valueâ
>     drivers/gpu/drm/bridge/ptn3460.c: In function âptn3460_probeâ:
>     drivers/gpu/drm/bridge/ptn3460.c:333: error: implicit declaration of function âdevm_gpiod_getâ
>     drivers/gpu/drm/bridge/ptn3460.c:333: warning: assignment makes pointer from integer without a cast
>     drivers/gpu/drm/bridge/ptn3460.c:340: error: implicit declaration of function âgpiod_direction_outputâ
>     drivers/gpu/drm/bridge/ptn3460.c:346: warning: assignment makes pointer from integer without a cast
> 
> Add the missing #include <linux/gpio/consumer.h> to fix this.
> 
> As the resulting driver won't work with GPIOLIB=n anyway, make
> DRM_PTN3460 depend on GPIOLIB || COMPILE_TEST.
> 
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> ---
>  drivers/gpu/drm/bridge/Kconfig   | 4 ++--
>  drivers/gpu/drm/bridge/ptn3460.c | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)

Applied, thanks. Note that I dropped the part about adding the GPIOLIB
dependency because that had been attempted previously to fix this, but
it causes recursive dependencies on PowerPC (ppc64_defconfig). I don't
know of a way to untangle those (I tried and failed miserably), so I
think adding the include is really as good as it'll get.

Thierry

Attachment: pgpmNr5GfxU2g.pgp
Description: PGP signature