Re: [PATCH v4 1/5] fs: kiocb: introduce IOCB_DONT_DIRTY_PAGE flag for direct IO

From: Christoph Hellwig
Date: Fri Jun 05 2015 - 11:04:01 EST


As mentioned last time a big fat NAK for this one. We generally
do not dirty kernel pages anywhere, so a flag that must alway be set
for default behavior just to prepare for a highy hypothetical user that
in the future might want to abuse the interface is a no-go.

Just make the dirtying behavior dependent on the iov_iter type:
dirty for ITER_IOVEC and do nothing for ITER_KVEC and ITER_BVEC.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/