Re: False positive in checkpatch.pl ?

[Joe Perches]

On Fri, 2015-06-05 at 10:21 -0700, Aseda Aboagye wrote:
> Hello CHECKPATCH maintainers,
> 
> I encountered this error when using the checkpatch.pl script
> complaining about my macro.
> 
>         Errors:
>             * checkpatch.pl errors/warnings
> 
>             ERROR: Macros with complex values should be enclosed in parenthesis
>             #92: FILE: include/libsharedobjs.h:28:
>             +#define SHAREDLIB(...) __attribute__
> ((section(".roshared"))) __VA_ARGS__
> 
>             total: 1 errors, 0 warnings, 45 lines checked
> 
> Since it's really an attribute, adding the parens wouldn't work. Just
> thought I'd send this your way. Perhaps make an exception for cases
> like these?

SHAREDLIB is not used in the kernel tree.
Maybe add an exception in your own checkpatch version.

Though maybe adding a SHAREDLIB macro without the ... and
make it a simple #define instead like below would be better

#define SHAREDLIB	__attribute__((section(".roshared")))


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/