Re: [PATCH v2 3/3] net/phy: micrel: Center FLP timing at 16ms

[Jaeden Amero]

On 06/05/2015 04:09 PM, Sergei Shtylyov wrote:
>> @@ -441,6 +461,7 @@ static int ksz9031_config_init(struct phy_device
>> *phydev)
>>           "txd2-skew-ps", "txd3-skew-ps"
>>       };
>>       static const char *control_skews[2] = {"txen-skew-ps",
>> "rxdv-skew-ps"};
>> +    int result;
> 
>    You hardly need this variable...
> 
>>
>>       if (!of_node && dev->parent->of_node)
>>           of_node = dev->parent->of_node;
>> @@ -462,7 +483,10 @@ static int ksz9031_config_init(struct phy_device
>> *phydev)
>>                   MII_KSZ9031RN_TX_DATA_PAD_SKEW, 4,
>>                   tx_data_skews, 4);
>>       }
>> -    return 0;
>> +
>> +    result = ksz9031_center_flp_timing(phydev);
>> +
>> +    return result;
> 
>    Why not just return directly?
> 

Genius.

Thanks for the feedback. I'll post a v3.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/