Re: [PATCH v2 4/4] VFIO: platform: Calxeda xgmac reset module

[Paul Bolle]

On Fri, 2015-06-05 at 17:06 +0200, Eric Auger wrote:
> --- /dev/null
> +++ b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c

> +static int __init vfio_platform_calxedaxgmac_init(void)
> +{
> +	return 0;
> +}
> +
> +static void __exit vfio_platform_calxedaxgmac_exit(void)
> +{
> +}
> +
> +module_init(vfio_platform_calxedaxgmac_init);
> +module_exit(vfio_platform_calxedaxgmac_exit);

Just a nit: I think it's OK to leave out these functions if they both do
nothing. See delete_module in kernel/module.c.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/