Re: [PATCH 4/4] media: pxa_camera: conversion to dmaengine

From: Robert Jarzmik
Date: Sun Jun 07 2015 - 15:19:53 EST


Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes:

> Hi Robert,
>
> Please, correct me if I am wrong, but doesn't this patch have to be
> updates? Elgl looking at this:
>> + for (i = 0; i < 3 && buf->descs[i]; i++) {
>> + async_tx_ack(buf->descs[i]);
>> + dmaengine_tx_release(buf->descs[i]);
>
> hasn't the addition of your proposed dmaengine_tx_release() API been
> rejected? I'll wait for an updated version then.
Yeah, correct.
The updated version will just remove the dmaengine_tx_release() call, the
async_tx_ack() is sufficient.

I hope this won't stop the review, it's the only change I have so far in my tree
on top of the submission.

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/