Re: [RESEND 1/2] usb: ehci-exynos: Make provision for vdd regulators

From: Javier Martinez Canillas
Date: Mon Jun 08 2015 - 02:43:04 EST


Hello,

On Mon, Jun 8, 2015 at 7:14 AM, Krzysztof Kozlowski
<k.kozlowski@xxxxxxxxxxx> wrote:

[...]

>
> To summarize my point of view:
> 1. Unless Vivek's says otherwise, please give him the credits with
> proper "from" field.
> 2. Issues mentioned in previous mail should be addressed (missing
> IS_ERR(), how disabling the regulator during suspend affects waking
> up).
> 3. The patchset must be tested, even after rebasing.
>

Agreed with all the points.

Anand,

An easy way to preserve authorship when rebasing patches is to use the
git command author option. As an example you can execute the following
command:

$ git commit -a -s --author='Vivek Gautam <gautam.vivek@xxxxxxxxxxx>'

> Best regards,
> Krzysztof

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/