Re: [PATCH v4 5/7] Watchdog: introduce ARM SBSA watchdog driver
From: Guenter Roeck
Date: Tue Jun 09 2015 - 12:46:28 EST
On 06/09/2015 09:29 AM, Timur Tabi wrote:
On 06/09/2015 11:22 AM, Guenter Roeck wrote:
but I see your point. Essentially, the specification is broken
for all practical purposes, since, as you point out, enabling
the watchdog overwrites and explicitly sets WCV. Effectively
this means that just using WCV to program the timeout period
is not really possible.
I am not really sure how to address this. We can either only use WOR,
and forget about pretimeout, or we can enforce a minimum pretimeout.
In the latter case, we'll have to write WCV after writing WOR.
In talking with our hardware engineers, using WCV to program the timeout period is not a valid operation. This is why I keep arguing against the pre-timeout feature, and I don't agree that servers should always use pre-timeout.
Not sure if "not valid" is correct - after all, it is mentioned in the
specification. However, it is at the very least fragile.
I tend to agree that we should just forget about pretimeout and
use your original approach, where the timeout value is used
to program WOR. Everything else is really just asking for trouble.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/