Re: [RFC PATCH 01/12] mm: add a new config to manage the code

[Kamezawa Hiroyuki]

On 2015/06/09 19:10, Xishi Qiu wrote:
> On 2015/6/9 14:44, Kamezawa Hiroyuki wrote:
>
> > On 2015/06/04 21:56, Xishi Qiu wrote:
> > > This patch introduces a new config called "CONFIG_ACPI_MIRROR_MEMORY", it is
> > > used to on/off the feature.
> > >
> > > Signed-off-by: Xishi Qiu <qiuxishi@xxxxxxxxxx>
> > > ---
> > >    mm/Kconfig | 8 ++++++++
> > >    1 file changed, 8 insertions(+)
> > >
> > > diff --git a/mm/Kconfig b/mm/Kconfig
> > > index 390214d..4f2a726 100644
> > > --- a/mm/Kconfig
> > > +++ b/mm/Kconfig
> > > @@ -200,6 +200,14 @@ config MEMORY_HOTREMOVE
> > >        depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE
> > >        depends on MIGRATION
> > >
> > > +config MEMORY_MIRROR
> > > +    bool "Address range mirroring support"
> > > +    depends on X86 && NUMA
> > > +    default y
> > > +    help
> > > +      This feature depends on hardware and firmware support.
> > > +      ACPI or EFI records the mirror info.
> >
> > default y...no runtime influence when the user doesn't use memory mirror ?
>
> It is a new feature, so how about like this: default y -> n?

It's okay to me. But it's better to check performance impact before merge
because you modified core code of memory management.

Thanks,
-Kame
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/