Re: [PATCH] x86/asm/entry/32, selftests: Add test_syscall_vdso test

From: Steven Rostedt
Date: Wed Jun 10 2015 - 18:37:22 EST


On Wed, 10 Jun 2015 22:15:58 +0200
Denys Vlasenko <dvlasenk@xxxxxxxxxx> wrote:

> On 06/10/2015 10:00 PM, Kees Cook wrote:
> >> + printf("[SKIP]\tAT_SYSINFO not supplied, can't test\n");
> >> + exit(0); /* this is not a test failure */
> >
> > Why is that not a test failure? It would mean it didn't actually test
> > anything, which seems like a failure to me.
>
> Are you objecting to comment wording, or to exiting with 0?
>
> I exit with 0 because no bug was detected.

I believe there's a way to exit with "not supported". That's what the
ftrace tests do.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/