Re: [PATCH 1/1 linux-next] ath5k: use swap() in ath5k_hw_get_median_noise_floor()

[Fabian Frederick]

> On 10 June 2015 at 22:29 Julia Lawall <julia.lawall@xxxxxxx> wrote:
>
>
>
>
> On Wed, 10 Jun 2015, Fabian Frederick wrote:
>
> >
> >
> > > On 10 June 2015 at 21:52 Joe Perches <joe@xxxxxxxxxxx> wrote:
> > >
> > >
> > > On Wed, 2015-06-10 at 18:33 +0200, Fabian Frederick wrote:
> > > > Use kernel.h macro definition.
> > > >
> > > > Thanks to Julia Lawall for Coccinelle scripting support.
> > > []
> > > > diff --git a/drivers/net/wireless/ath/ath5k/phy.c
> > > > b/drivers/net/wireless/ath/ath5k/phy.c
> > > []
> > > > @@ -1566,17 +1566,13 @@ static s16
> > > >Â ath5k_hw_get_median_noise_floor(struct ath5k_hw *ah)
> > > >Â {
> > > >Â Â Âs16 sort[ATH5K_NF_CAL_HIST_MAX];
> > > > -Â Âs16 tmp;
> > > >Â Â Âint i, j;
> > > >Â
> > > >Â Â Âmemcpy(sort, ah->ah_nfcal_hist.nfval, sizeof(sort));
> > > >Â Â Âfor (i = 0; i < ATH5K_NF_CAL_HIST_MAX - 1; i++) {
> > > >Â Â Â Â Â Â Âfor (j = 1; j < ATH5K_NF_CAL_HIST_MAX - i; j++) {
> > > > -Â Â Â Â Â Â Â Â Â Âif (sort[j] > sort[j - 1]) {
> > > > -Â Â Â Â Â Â Â Â Â Â Â Â Â Âtmp = sort[j];
> > > > -Â Â Â Â Â Â Â Â Â Â Â Â Â Âsort[j] = sort[j - 1];
> > > > -Â Â Â Â Â Â Â Â Â Â Â Â Â Âsort[j - 1] = tmp;
> > > > -Â Â Â Â Â Â Â Â Â Â}
> > > > +Â Â Â Â Â Â Â Â Â Âif (sort[j] > sort[j - 1])
> > > > +Â Â Â Â Â Â Â Â Â Â Â Â Â Âswap(sort[j], sort[j]);
> > >
> > > swap(a, a) doesn't look useful.
> > Thanks a lot Joe, I'll fix this one :)
>
> How did it come out like that?
>
> julia

I used script for detection only and made updates manually.
I guess I was distracted by [j - 1] on line above.
It was based on linux-next; if maintainers prefer another branch, I'll
send the right version on top of it.

Regards,
Fabian
>
> >
> > Regards,
> > Fabian
> > >
> > >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/