Re: [PATCH v5 02/10] x86: Compile-time asm code validation

[Ingo Molnar]

* Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> I should also mention that my proposed ia32_ptregs_common patch, which 
> duplicated the needed code, was more optimized for performance than code size.
> 
> But if you're more worried about code size, we could turn ia32_ptregs_common 
> into a proper callable function, and then replace
> 
>    jmp ia32_ptregs_common
> 
> with:
> 
>    call ia32_ptregs_common
>    ret
> 
> So it becomes a regular call instead of a tail call.  It only adds a few 
> instructions and the function is self-contained.  Would that be good enough?

No, debug info should not slow down the kernel, especially not code we write in 
assembly partly for performance.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/