Re: [PATCH 2/6] clocksource: arm_global_timer: Migrate to new 'set-state' interface

[Daniel Lezcano]

On 06/11/2015 04:56 PM, Viresh Kumar wrote:
> On 11-06-15, 16:49, Daniel Lezcano wrote:
> > Acked-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
>
> Thanks :)
>
> > > -	clk->set_mode = gt_clockevent_set_mode;
> > > +	clk->set_state_shutdown = gt_clockevent_shutdown;
> > > +	clk->set_state_periodic = gt_clockevent_set_periodic;
> > > +	clk->set_state_oneshot = gt_clockevent_shutdown;
> >
> > nit: it sounds weird to use the same function as the purpose of the
> > patch is use the new API which is to ventilate those functions
> > (anyway ...)
>
> Hmm, but there is no point creating two routines to do exactly the
> same thing. And this is making it evident that we actually shutdown
> the device in oneshot-state request. And enable it only when the next
> event is programmed.

Yes, this is really a detail.


--
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/