Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code

From: Linus Torvalds
Date: Thu Jun 11 2015 - 16:38:00 EST


On Thu, Jun 11, 2015 at 7:07 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> But we want to remove the pgd_list, so convert the code over to walk
> all tasks in the system. This is an equivalent method.

This is not at all equivalent, and it looks stupid.

Don't use "for_each_process_thread(g, p)". You only care about each
mm, and threads all share the same mm, so just do

for_each_process(p)

instead of iterating over all threads too.

No?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/