Re: [PATCH] kernel/params.c: make use of unused but set variable

[Tejun Heo]

On Fri, Jun 12, 2015 at 10:57:24AM +0930, Rusty Russell wrote:
> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes:
> > On Sun, Jun 7, 2015 at 5:00 PM, Tejun Heo <htejun@xxxxxxxxx> wrote:
> > At most, it could be a "WARN_ON_ONCE()". Maybe even just silently
> > ignore the error. But BUG_ON()? Hell no.
> 
> Yeah, in practice it's already (1) paniced if we ran out of memory, or
> (2) warned if we somehow tried to create two entries with the same name.
> 
> So the WARN_ON_ONCE() is a bit... meh.  How's this, too snarky?

Sounds pretty passive agressive to me.  At least reply to the actual
argument?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/