Re: [PATCH] drivers/video/fbdev/sis/sis_main.c: avoid repeated strlen() calls

From: Tomi Valkeinen
Date: Fri Jun 12 2015 - 05:36:33 EST




On 09/06/15 16:04, Rasmus Villemoes wrote:
> gcc is not smart enough to realize that strlen(strbuf1) cannot be
> changed by the loop body, so it is forced to recompute it, at least in
> the branch containing the assignment. Avoid this by using an
> equivalent stopping condition.

Does it matter? Is sisfb calling sisfb_search_mode thousands of times?

Tomi

Attachment: signature.asc
Description: OpenPGP digital signature