Re: [PATCH 2/3] sb_edac: virtualize several hard-coded functions

[Aristeu Rozanski]

Hi Jim, Lukasz,
On Tue, Jun 09, 2015 at 01:43:11PM +0200, lukasz.anaczkowski@xxxxxxxxx wrote:
> @@ -273,6 +270,10 @@ struct sbridge_info {
>  	u64		(*get_tolm)(struct sbridge_pvt *pvt);
>  	u64		(*get_tohm)(struct sbridge_pvt *pvt);
>  	u64		(*rir_limit)(u32 reg);
> +	u64		(*sad_limit)(u32 reg);
> +	u32		(*interleave_mode)(u32 reg);
> +	char*		(*show_interleave_mode)(u32 reg);
> +	u32		(*dram_attr)(u32 reg);
>  	const u32	*dram_rule;
>  	const u32	*interleave_list;
>  	const struct interleave_pkg *interleave_pkg;

the only reason these exist is for when there's a difference between
memory controllers:
>  		pvt->info.get_memory_type = get_memory_type;

>  		pvt->info.get_memory_type = get_memory_type;

>  		pvt->info.get_memory_type = haswell_get_memory_type;

until then such change isn't really necessary.

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/