Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options

[Alexei Starovoitov]

On 6/11/15 10:35 PM, Wang Nan wrote:
>          # Path to clang. If omit, search it from $PATH.
> 	clang-path = "/path/to/clang"

I think this bit and search_program() from the next patch is
overly flexible. It's always delicate to search file paths.
Unless this is really needed, I would drop this bit.
popen() in the next patch executes clang via shell,
so explicit PATH search in unnecessary.

The rest of the patches look good to me.
Thanks again.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/