Re: [PATCH 04/12] x86/mm/hotplug: Simplify sync_global_pgds()

[Ingo Molnar]

* Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> Yes I guess I am totally confused ;)
> 
> On 06/11, Ingo Molnar wrote:
> >
> > @@ -178,7 +178,7 @@ void sync_global_pgds(unsigned long start, unsigned long end, int removed)
> >  		 *
> >  		 * So clear the affected entries in every process PGD as well:
> >  		 */
> > -		if (pgd_none(*pgd_ref) && !removed)
> > +		if (pgd_none(*pgd_ref))
> 
> But doesn't this change invalidate the comment above?

Indeed - I fixed the comment to now say:

                /* Only sync (potentially) newly added PGD entries: */
                if (pgd_none(*pgd_ref))
                        continue;

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/