Re: [PATCH net-next] Increase limit of macvtap queues

[Michael S. Tsirkin]

On Fri, Jun 12, 2015 at 07:00:28PM +0530, Pankaj Gupta wrote:
> Macvtap should be compatible with tuntap for maximum number
> of queues. '1059590254fa9dce9cafc4f07d1103dbec415e76' removes
> the limitation and increases number of queues in tuntap.
> Now, Its safe to increase number of queues in Macvtap as well.
> 
> Signed-off-by: Pankaj Gupta <pagupta@xxxxxxxxxx>

It's a good idea, but this might be a problem:

static void macvtap_del_queues(struct net_device *dev)
{
        struct macvlan_dev *vlan = netdev_priv(dev);
        struct macvtap_queue *q, *tmp, *qlist[MAX_MACVTAP_QUEUES];

...
}

by itself, this will use 2K on stack, which seems too much.

You need to rework this function to use a linked list + list_move
instead of an array + list_del_init.

> ---
>  include/linux/if_macvlan.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/if_macvlan.h b/include/linux/if_macvlan.h
> index 6f6929e..a4ccc31 100644
> --- a/include/linux/if_macvlan.h
> +++ b/include/linux/if_macvlan.h
> @@ -29,7 +29,7 @@ struct macvtap_queue;
>   * Maximum times a macvtap device can be opened. This can be used to
>   * configure the number of receive queue, e.g. for multiqueue virtio.
>   */
> -#define MAX_MACVTAP_QUEUES     16
> +#define MAX_MACVTAP_QUEUES     256
> 
>  #define MACVLAN_MC_FILTER_BITS 8
>  #define MACVLAN_MC_FILTER_SZ   (1 << MACVLAN_MC_FILTER_BITS)
> --
> 1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/