Re: [PATCH 1/1] pcmcia: Fix resource leaks in yenta_probe() and _close()

From: Dominik Brodowski
Date: Sun Jun 14 2015 - 15:53:17 EST


On Mon, Jun 15, 2015 at 02:43:59AM +0900, Takeshi Yoshimura wrote:
> There are some resource leaks in yenta_probe() and _close(). I fixed
> the following issues with some code cleanups. Thanks to Dominik's
> suggestions.
>
> On the error path in yenta_probe():
> - a requested irq is not released
> - yenta_free_resources() and pci_set_drvdata(dev, NULL) are not called
>
> In yenta_close():
> - kfree(sock) is not called
> - sock->base is always set to non-NULL when yenta_close() is called,
> therefore the check in yenta_close() is not necessary.
>
> Signed-off-by: Takeshi Yoshimura <yos@xxxxxxxxxxxxxxxxxxxx>

Applied to the PCMCIA tree. Many thanks!

Dominik

Attachment: signature.asc
Description: Digital signature