Re: [PATCH 5/5] serial/8250_fintek: Support for any io address.

[Ricardo Ribalda Delgado]

Hello Alan

On Mon, Jun 15, 2015 at 4:25 PM, Alan Cox <alan@xxxxxxxxxxxxxxx> wrote:

>
> Please however fix the dynamic on stack arrays you've got. Doing
>
>         blah foo[] = { 1,2,3,4 };
>
> might well be valid gcc but it generates horrible code when in fact your
> arrays should be static/const, not dynamically constructed on stack from
> a static copy each call.

Thanks for the comments, I have resubmitted the patchset.

>
> Reviewed-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/