Re: [V6 PATCH 0/7] ACPI: Introduce support for _CCA object

[Suravee Suthikulpanit]

Thank you.

Suravee

On 6/15/15 18:24, Rafael J. Wysocki wrote:
> On Wednesday, June 10, 2015 11:08:51 AM Suravee Suthikulpanit wrote:
> > This patch series introduce support for _CCA object, which is currently
> > used mainly by ARM64 platform to specify DMA coherency attribute for
> > devices when booting with ACPI.
> >
> > A copy of ACPIv6 can be found here:
> >      http://www.uefi.org/sites/default/files/resources/ACPI_6.0.pdf
> >
> > This patch also introduces a new APIS:
> >      1. acpi_check_dma() as part of ACPI API.
> >      2. device_dma_is_coherent() as part of unified device property API.
> >
> > This simplifies the logic in device drivers to determine device coherency
> > attribute regardless of booting with DT vs ACPI.
> >
> > This has been tested on AMD-Seattle platform, which implements _CCA
> > object as described in the AMD Opteron A1100 Series Processor ACPI Porting Guide:
> >
> > http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2012/10/Seattle_ACPI_Guide.pdf
> >
> > Changes from V5 (https://lkml.org/lkml/2015/5/20/1033):
> >      * Fix build error in the megaraid and ufs driver
> >        (reported by Mark Salter)
> >
> > Changes from V4 (https://lkml.org/lkml/2015/5/15/669):
> >      * Patch1:
> >        - Move the arch_setup_dma_ops() call from acpi_create_platform_device()
> >          to acpi_bind_one() to support other bus types (per Rafael).
> >        - Rename acpi_device_flags.is_coherent to acpi_device_flags.coherent_dma.
> >          (per Rafael)
> >        - Refactor acpi_dma_is_supported() and acpi_dma_is_coherent() to
> >          acpi_check_dma() to simplify the new interface.
> >        - Only support _CCA=1 for now. See acpi_check_dma() (per Arnd and Catalin)
> >      * Patch2:
> >        - Add acked-by Catalin.
> >      * Patch3:
> >        - Use ACPI_COMPANION() instead of acpi_node().
> >        - Remove has_acpi_companion() check since already done by acpi_node().
> >          (per Will)
> >      * Remove the patch "Generic function for setting up PCI device DMA coherency"
> >        introduced in V4. (per Bjorn)
> >
> > Changes from V3 (https://lkml.org/lkml/2015/5/7/1004):
> >      * Remove ARCH64_SUPPORT_ACPI_CCA_ZERO and just use CONFIG_ARM64.
> >        (per Catalin and Rafael)
> >      * Do not need to call arch_setup_dma_ops() for acpi_device->dev.
> >        (per Rafael)
> >      * [3/6] (New) We also need to call arch_setup_dma_ops() for pci
> >        devices and check the CCA of the host bridge. Similar logic
> >        exists for OF. So, I refactor of_pci_dma_configure() to
> >        the more generic version pci_dma_configure(), and add support
> >        for ACPI.
> >
> > Changes from V2 (https://lkml.org/lkml/2015/5/5/510):
> >      * Reword ACPI_MUST_HAVE_CCA to ACPI_CCA_REQUIRED (per Rafael)
> >      * Reword ACPI_SUPPORT_CCA_ZERO to ARCH64_SUPPORT_ACPI_CCA_ZERO
> >        (per Rafael and Arnd)
> >      * Misc code styling clean up (per Rafael)
> >      * Only print missing _CCA warning message in debug mode.
> >      * Refactor logic in acpi_setup_device_dma() into
> >        if acpi_dma_is_supported() then call arch_setup_dma_ops().
> >      * Do not allocate device dma_mask if !acpi_dma_is_supported()
> >        (per Arnd).
> >      * Re-use the dummy functions with the same signature.
> >
> > Changes from V1 (https://lkml.org/lkml/2015/4/29/290):
> >      * Remove supports for 32-bit ARM since doesn't currently
> >        supporting ACPI (Per Catalin suggestions.)
> >      * Do not call arch_setup_dma_ops() and when _CCA is missing.
> >        (per Arnd suggestion)
> >      * Add CONFIG_ACPI_SUPPORT_CCA_ZERO kernel config flag to
> >        allow architectures to specify the behavior when _CCA=0.
> >      * Add dummy_dma_ops for ARM64 (per Catalin suggestions).
> >      * Fixed build error when ACPI is not configured by defining
> >        acpi_dma_is_coherent() for when CONFIG_ACPI is not set.
> >      * Introduce device_dma_is_coherent().
> >      * Use device_dma_is_coherent in crypto/ccp and amd-xgbe driver.
> >
> > Changes from RFC: (https://lkml.org/lkml/2015/4/1/389)
> >      * New logic for deriving and propagating coherent attribute from
> >        parent devices. (by Mark)
> >      * Introducing acpi_dma_is_coherent() API (Per Tom suggestion)
> >      * Introducing CONFIG_ACPI_MUST_HAVE_CCA kernel configuration.
> >      * Rebased to linux-4.1-rc1
> >
> > Suravee Suthikulpanit (7):
> >    ACPI / scan: Parse _CCA and setup device coherency
> >    arm64 : Introduce support for ACPI _CCA object
> >    device property: Introduces device_dma_is_coherent()
> >    crypto: ccp - Unify coherency checking logic with
> >      device_dma_is_coherent()
> >    amd-xgbe: Unify coherency checking logic with device_dma_is_coherent()
> >    megaraid_sas: fix TRUE and FALSE re-define build error
> >    ufs: fix TRUE and FALSE re-define build error
> >
> >   arch/arm64/Kconfig                        |  1 +
> >   arch/arm64/include/asm/dma-mapping.h      | 18 +++++-
> >   arch/arm64/mm/dma-mapping.c               | 92 +++++++++++++++++++++++++++++++
> >   drivers/acpi/Kconfig                      |  3 +
> >   drivers/acpi/acpi_platform.c              |  2 +-
> >   drivers/acpi/glue.c                       |  5 ++
> >   drivers/acpi/scan.c                       | 35 ++++++++++++
> >   drivers/base/property.c                   | 14 +++++
> >   drivers/crypto/ccp/ccp-platform.c         | 60 +-------------------
> >   drivers/net/ethernet/amd/xgbe/xgbe-main.c | 27 +--------
> >   drivers/scsi/megaraid/megaraid_sas_fp.c   |  8 +++
> >   drivers/scsi/ufs/unipro.h                 |  8 +++
> >   include/acpi/acpi_bus.h                   | 37 ++++++++++++-
> >   include/linux/acpi.h                      |  5 ++
> >   include/linux/property.h                  |  2 +
> >   15 files changed, 228 insertions(+), 89 deletions(-)
>
> I've queued up the series for 4.2, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/